Skip to content

Suggest replacing a field when using the same type #95396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2022
Merged

Suggest replacing a field when using the same type #95396

merged 2 commits into from
Mar 28, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Mar 28, 2022

closes #89166

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 28, 2022
@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2022
@TaKO8Ki TaKO8Ki changed the title Suggest replacing field when using the same type Suggest replacing a field when using the same type Mar 28, 2022
compiler-errors
compiler-errors reviewed Mar 28, 2022
View reviewed changes
@TaKO8Ki TaKO8Ki requested a review from compiler-errors March 28, 2022 04:49
@compiler-errors
Copy link
Member

Great, looks like issue-51102 got fixed in c26cfd1 when you changed it to coerce.

r? @compiler-errors
@bors r+

@bors
Copy link
Collaborator

bors commented Mar 28, 2022

📌 Commit c26cfd1 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2022
@bors
Copy link
Collaborator

bors commented Mar 28, 2022

⌛ Testing commit c26cfd1 with merge b3e46a9...

@bors
Copy link
Collaborator

bors commented Mar 28, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing b3e46a9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2022
@bors bors merged commit b3e46a9 into rust-lang:master Mar 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 28, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b3e46a9): comparison url.

Summary: This benchmark run did not return any relevant results. 5 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Don't suggest replacing a field when the fix does not type checks
7 participants
@TaKO8Ki @rust-highfive @compiler-errors @bors @rust-timer @matthewjasper @rustbot