extra::ringbuf: Implement method .swap(uint, uint) just like vector
#9520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RingBuf::swap(&mut self, i, j) swaps the element at indices `i` and `j` if both elements are in bounds, otherwise it fails.
bors
added a commit
that referenced
this pull request
Sep 26, 2013
extra::ringbuf: Implement method `.swap(uint, uint)` just like vector RingBuf::swap(&mut self, i, j) swaps the element at indices `i` and `j` if both elements are in bounds, otherwise it fails.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
more than just `&self` in non-standard implementations. changelog: Fix [`len_without_is_empty`] false positive when len has a non-standard method signature Fixes rust-lang#9520
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
prevents `len_without_is_empty` from yielding positive when `len` takes arguments besides `&self` Fixes rust-lang#9520 --- changelog: FP [`len_without_is_empty`]: No longer lints, if `len` as a non-default signature [rust-lang#10255](rust-lang/rust-clippy#10255) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra::ringbuf: Implement method
.swap(uint, uint)just like vectorRingBuf::swap(&mut self, i, j) swaps the element at indices
iandjif both elements are in bounds, otherwise it fails.