Skip to content

Period "." in file or #[link name causes custom extension executable instead of .exe #10255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SecondNature opened this issue Nov 4, 2013 · 4 comments

Comments

@SecondNature
Copy link

[link(name = "fff.eee")

The output generates a windows executable with the extension ".eee" as opposed to "fff.eee.exe".

Adding the ".exe" manually will reduce platform independence.

Bug or feature? Implications of a change?

@steveklabnik
Copy link
Member

Is this issue still valid at all? I don't have windows, so I can't check.

@SecondNature
Copy link
Author

Many language changes since then

#[link(name = "test.eee")]
generates
libtest.rlib

But it is getting the name from #![crate_name = "test"] which if I add a "." returns
test.rs:2:1: 2:28 error: invalid character . in crate name: test.eee
test.rs:2 #![crate_name = "test.eee"]

I would think you wouldn't want to reduce the variability. If that is the desired output or not I will leave for you or others.

@SecondNature
Copy link
Author

Because no '.' ( periods ) can be placed in #![crate_name(s) it is not possible to create version numbers using periods. ie app1.0.exe

Windows - rustc 0.12.0-pre-nightly (aa0e35b 2014-07-22 00:26:21 +0000)

@steveklabnik
Copy link
Member

GIven that crate names are identifiers, and that #[link] is gone, I think this issue is now moot.

flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 10, 2023
prevents `len_without_is_empty` from yielding positive when `len` takes arguments besides `&self`

Fixes rust-lang#9520

---

changelog: FP [`len_without_is_empty`]: No longer lints, if `len` as a non-default signature
[rust-lang#10255](rust-lang/rust-clippy#10255)
<!-- changelog_checked -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants