Skip to content

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 10, 2022

This was part of @Mark-Simulacrum 's original PR in ecb424f,
but I missed it when writing #92260.

This also has the side effect of allowing cargo build --bins instead of cargo build -p bootstrap --bins. I'm not sure when you would want to run cargo build/check/test without going through bootstrap, but this still allows you to do so as long as you pass -p for all the crates you want to build.

This was part of Mark's original PR in rust-lang@ecb424f,
but I missed it when writing rust-lang#92260.
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2022
@Mark-Simulacrum
Copy link
Member

I think -p is basically necessary (or --manifest-path) if you want cargo check/build/test to be viable, since otherwise the chances of avoiding sysroot expectations are near-zero, I suspect. (In any case, not worried about slightly changing or altering the behavior there).

This seems harmless or good otherwise.

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 10, 2022

📌 Commit 687e53e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#94440 (Better error for normalization errors from parent crates that use `#![feature(generic_const_exprs)]`)
 - rust-lang#94587 (Document new recommended use of `FromIterator::from_iter`)
 - rust-lang#94644 (Fix soundness issue in scoped threads.)
 - rust-lang#94740 (Unify impl blocks by wrapping them into a div)
 - rust-lang#94753 (Improve rustdoc book)
 - rust-lang#94796 (Allow `cargo run` instead of `cargo run -p bootstrap`)
 - rust-lang#94805 (Revert accidental stabilization)
 - rust-lang#94809 (RustWrapper: add missing include)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fa685a5 into rust-lang:master Mar 10, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 10, 2022
@jyn514 jyn514 deleted the cargo-run-bootstrap branch March 10, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants