Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 6, 2022

We need that to implement simd_cast/simd_as in Miri.

While at it, also change other code outside cast.rs to use misc_cast instead of lower-level methods.

r? @oli-obk

@rust-highfive
Copy link
Contributor

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 6, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 6, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 6, 2022

📌 Commit d29d230 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2022
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#94636 (Check extra function arg exprs even if the fn is not C-variadic)
 - rust-lang#94676 (Remove unnecessary `..` patterns)
 - rust-lang#94681 (CTFE engine: expose misc_cast to Miri)
 - rust-lang#94684 (Fix rustdoc for GATs with with anonymous bound regions)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f7eb383 into rust-lang:master Mar 7, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 7, 2022
bors added a commit to rust-lang/miri that referenced this pull request Mar 7, 2022
implement more SIMD intrinsics

Requires rust-lang/rust#94681

With this, the cast, i32_ops, and f32_ops test suites of portable-simd pass. :)

Cc #1912
@RalfJung RalfJung deleted the miri-cast branch March 7, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants