Link sidebar "location" heading to top of page #92795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jsha
force-pushed
the
link-to-top
branch
2 times, most recently
from
c01a36f to
a75d0b2
Compare
| @@ -66,6 +66,7 @@ | |||
| {{- layout.external_html.in_header | safe -}} | |||
| </head> {#- -#} | |||
| <body class="rustdoc {{page.css_class}}"> {#- -#} | |||
| <a id="top"></a> | |||
There was a problem hiding this comment.
Since #92043 hasn't been merged yet, please add this ID in the ID map. ;)
|
I think adding a rustdoc test to ensure that the "location" element is a link would be a good idea too. |
|
☔ The latest upstream changes (presumably #92526) made this pull request unmergeable. Please resolve the merge conflicts. |
This makes it easy, when you are scrolled far down in a page, to jump back to the top.
|
It turns out |
GuillaumeGomez
approved these changes
Jan 15, 2022
I didn't know that, thanks for the new knowledge! :) @bors: r+ rollup |
|
📌 Commit 7781636 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 17, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#92795 (Link sidebar "location" heading to top of page) - rust-lang#92799 (Remove some unnecessary uses of `FieldDef::ident`) - rust-lang#92808 (Fix `try wrapping expression in variant` suggestion with struct field shorthand) - rust-lang#92819 (rustdoc: remove hand-rolled isatty) - rust-lang#92876 (Fix suggesting turbofish with lifetime arguments) - rust-lang#92921 (Rename Printer constructor from mk_printer() to Printer::new()) - rust-lang#92937 (rustdoc: Add missing dot separator) - rust-lang#92953 (Copy an example to PartialOrd as well) - rust-lang#92977 (Docs: recommend VecDeque instead of Vec::remove(0)) - rust-lang#92981 (fix const_ptr_offset_from tracking issue) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easy, when you are scrolled far down in a page, to jump back to the top.
Demo: https://rustdoc.crud.net/jsha/link-to-top/std/string/struct.String.html
r? @GuillaumeGomez