-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Do not display ~const Drop
in rustdoc
#92229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not display ~const Drop
in rustdoc
#92229
Conversation
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
fbd45d9
to
2e8b4a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! I'd noticed these pop up in the documentation of Option
.
@bors r+ |
📌 Commit 2e8b4a7 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (83bde52): comparison url. Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
Although
T: ~const Drop
is still at an experimental stage, we have already begun inserting these bounds in libstd. This change hides them from rustdoc because 1.~const
should not be documented in general as it is not yet official syntax; 2. users are not expected to know what~const Drop
means yet.