Add #[rustc_clean(loaded_from_disk)] to assert loading of query result
#92179
Conversation
Currently, you can use `#[rustc_clean]` to assert to that a particular query (technically, a `DepNode`) is green or red. However, a green `DepNode` does not mean that the query result was actually deserialized from disk - we might have never re-run a query that needed the result. Some incremental tests are written as regression tests for ICEs that occured during query result decoding. Using `#[rustc_clean(loaded_from_disk="typeck")]`, you can now assert that the result of a particular query (e.g. `typeck`) was actually loaded from disk, in addition to being green.
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit f1d6823 with merge 2214d3e77bea8be80a245351159c1781a52d7f71... |
|
☀️ Try build successful - checks-actions |
|
Queued 2214d3e77bea8be80a245351159c1781a52d7f71 with parent e100ec5, future comparison URL. |
|
Finished benchmarking commit (2214d3e77bea8be80a245351159c1781a52d7f71): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
LGTM, thanks @Aaron1011! @bors r+ |
|
📌 Commit f1d6823 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (b5efe57): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Currently, you can use
#[rustc_clean]to assert to that a particularquery (technically, a
DepNode) is green or red. However, a greenDepNodedoes not mean that the query result was actually deserializedfrom disk - we might have never re-run a query that needed the result.
Some incremental tests are written as regression tests for ICEs that
occured during query result decoding. Using
#[rustc_clean(loaded_from_disk="typeck")], you can now assertthat the result of a particular query (e.g.
typeck) was actuallyloaded from disk, in addition to being green.