Skip to content

When encountering a binding that could be a const or unit variant, suggest the right path #90988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2022
Merged

When encountering a binding that could be a const or unit variant, suggest the right path #90988

merged 2 commits into from
Apr 30, 2022

Conversation

estebank
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2021
@bors
Copy link
Collaborator

bors commented Jan 15, 2022

☔ The latest upstream changes (presumably #92441) made this pull request unmergeable. Please resolve the merge conflicts.

@wesleywiser
Copy link
Member

r? rust-lang/compiler-team

davidtwco
davidtwco approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit, address it if you'd like, r=me otherwise

@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2022
@apiraino
Copy link
Contributor

ping @estebank, I read this comment, do you have time to apply more changes or are we done here? thanks for an update :)

@estebank estebank force-pushed the binding-supposed-to-be-const branch from a8da88a to bce5ab2 Compare April 30, 2022 02:40
@estebank
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Apr 30, 2022

📌 Commit bce5ab2 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 30, 2022
@bors
Copy link
Collaborator

bors commented Apr 30, 2022

⌛ Testing commit bce5ab2 with merge 0c8e520...

@bors
Copy link
Collaborator

bors commented Apr 30, 2022

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 0c8e520 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 30, 2022
@bors bors merged commit 0c8e520 into rust-lang:master Apr 30, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 30, 2022
@bors bors mentioned this pull request Apr 30, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0c8e520): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@estebank estebank deleted the binding-supposed-to-be-const branch November 9, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.