Suggest adding a #[cfg(test)] to a test module
#90197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ogoffart
reviewed
Oct 23, 2021
apiraino
added
the
T-compiler
wesleywiser
reviewed
Oct 28, 2021
|
r? @estebank |
|
Could you review this PR? @wesleywiser @estebank |
wesleywiser
approved these changes
Nov 11, 2021
|
📌 Commit 3e43de4 has been approved by |
bors
added
S-waiting-on-bors
|
@wesleywiser Thank you! |
rhysd
reviewed
Nov 11, 2021
| visitor.r.local_def_id(unused.use_tree_id).to_def_id(), | ||
| ); | ||
| let test_module_span = match module_to_string(parent_module) { | ||
| Some(module) if module.contains("test") => Some(parent_module.span), |
There was a problem hiding this comment.
If my understanding is correct, this would detect modules like the followings as 'test' module.
mod fastest_search {
// ...
}
mod sohrtest_path {
// ...
}
mod bytestring {
// ...
}Is it intentional? I'm afraid that this loose check causes many false positives. I'd recommend to check more strictly like module == "test" || module == "tests".
There was a problem hiding this comment.
@wesleywiser I fixed this false positive. Could you review again?
There was a problem hiding this comment.
As of c597dc8, it looks good to me 👍
|
@bors r- |
bors
added
S-waiting-on-author
|
Could you review this PR again? @wesleywiser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #88138