-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Reuse existing shared Lrc for MatchImpl parent #89000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is hopefully a small performance win for the hot path.
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 905beab with merge 7673a3aaa9e105ce44a072adc092435bee541800... |
☀️ Try build successful - checks-actions |
Queued 7673a3aaa9e105ce44a072adc092435bee541800 with parent 4aed1ab, future comparison URL. |
Finished benchmarking commit (7673a3aaa9e105ce44a072adc092435bee541800): comparison url. Summary: This change led to very small relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r+ |
📌 Commit 905beab has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (aa8f2d4): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This is a small performance win for the hot path, which helps to address this regression: #87244 (comment).