Skip to content

AbstractConst private fields #88644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 21, 2021
Merged

AbstractConst private fields #88644

merged 7 commits into from
Oct 21, 2021

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Sep 4, 2021

Calls subst in AbstractConst::root when Node is Leaf.

r? @lcnr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2021
BoxyUwU
BoxyUwU requested changes Sep 4, 2021
View reviewed changes
lcnr
lcnr reviewed Sep 5, 2021
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a potential future bug for Node::Cast, apart from that, r=me

thanks ❤️

@lcnr lcnr changed the title AbstractConst private feilds AbstractConst private fields Sep 5, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 13, 2021
@eopb
Copy link
Contributor Author

eopb commented Sep 28, 2021

Is anything blocking this from being merged?

@BoxyUwU
Copy link
Member

BoxyUwU commented Sep 28, 2021

lcnr has a review about exhaustively matching on Node in .root() and also subst'ing the Ty in Node::Cast there

@JohnCSimon
Copy link
Member

ping from triage:
@eopb
Returning to you to address comments, please switch back to S-waiting-on-review.
thanks.

@rustbot label: +S-waiting-on-author -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2021
@eopb eopb requested a review from lcnr October 19, 2021 21:18
lcnr
lcnr requested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this r=me

@eopb eopb requested a review from lcnr October 20, 2021 09:19
@BoxyUwU
Copy link
Member

BoxyUwU commented Oct 20, 2021

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Oct 20, 2021

📌 Commit be30e60 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 20, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 21, 2021
@JohnTitor
Rollup merge of rust-lang#88644 - eopb:abstractconst_leaf_subst, r=lcnr
65c70d1 
`AbstractConst` private fields

Calls `subst` in `AbstractConst::root` when `Node` is `Leaf`.

r? `@lcnr`
@JohnTitor JohnTitor mentioned this pull request Oct 21, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request Oct 21, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2021
@bors
Auto merge of rust-lang#90119 - JohnTitor:rollup-e5t6khz, r=JohnTitor
e015ef5 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#86984 (Reject octal zeros in IPv4 addresses)
 - rust-lang#87440 (Remove unnecessary condition in Barrier::wait())
 - rust-lang#88644 (`AbstractConst` private fields)
 - rust-lang#89292 (Stabilize CString::from_vec_with_nul[_unchecked])
 - rust-lang#90010 (Avoid overflow in `VecDeque::with_capacity_in()`.)
 - rust-lang#90029 (Add test for debug logging during incremental compilation)
 - rust-lang#90031 (config: add the option to enable LLVM tests)
 - rust-lang#90048 (Add test for line-number setting)
 - rust-lang#90071 (Remove hir::map::blocks and use FnKind instead)
 - rust-lang#90074 (2229 migrations small cleanup)
 - rust-lang#90077 (Make `From` impls of NonZero integer const.)
 - rust-lang#90097 (Add test for duplicated sidebar entries for reexported macro)
 - rust-lang#90098 (Add test to ensure that the missing_doc_code_examples is not triggered on foreign trait implementations)
 - rust-lang#90099 (Fix MIRI UB in `Vec::swap_remove`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6f0acbc into rust-lang:master Oct 21, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 21, 2021
@eopb eopb deleted the abstractconst_leaf_subst branch October 21, 2021 11:07
@lcnr lcnr added the A-const-generics Area: const generics (parameters and arguments) label Dec 11, 2021
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU requested changes

@lcnr lcnr Awaiting requested review from lcnr

+1 more reviewer

@gilescope gilescope gilescope left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@lcnr lcnr

Labels
A-const-generics Area: const generics (parameters and arguments) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
9 participants
@eopb @BoxyUwU @JohnCSimon @bors @gilescope @lcnr @apiraino @rust-highfive @rustbot