Don't mark if_let_guard as an incomplete feature
#87937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
active-if-let-guards
branch
from
97adf45 to
a3cc6f5
Compare
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
active-if-let-guards
branch
from
a3cc6f5 to
dabdd6d
Compare
|
📌 Commit dabdd6d has been approved by |
bors
added
S-waiting-on-bors
8 tasks
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 26, 2021
…nagisa Use if-let guards in the codebase and various other pattern cleanups Dogfooding if-let guards as experimentation for the feature. Tracking issue rust-lang#51114. Conflicts with rust-lang#87937.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there is any reason for
if_let_guardto be an incomplete feature, and I think the reason they were marked in the first place was simply because they weren't implemented at all.r? @pnkfelix
cc tracking issue #51114