feat(rustc_lint): add dyn_drop
#86848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@rustbot label: +A-lint |
rustbot
added
the
A-lints
|
The actual implementation looks fine to me, but since adding new lints is a decision for the lang team, I'll defer to r? @scottmcm. |
|
Given that we have the @bors r=varkor since we can always tweak or remove it later. cc @rust-lang/lang just in case someone else has strong feelings |
|
📌 Commit 20e1791b9e54dff4fb96c9155a86bf7ca44105b4 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 20e1791b9e54dff4fb96c9155a86bf7ca44105b4 with merge 83e6f6d4ab726c5aa02bc0620946451c9807c8cd... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Based on the conversation in rust-lang#86747. Explanation ----------- A trait object bound of the form `dyn Drop` is most likely misleading and not what the programmer intended. `Drop` bounds do not actually indicate whether a type can be trivially dropped or not, because a composite type containing `Drop` types does not necessarily implement `Drop` itself. Naïvely, one might be tempted to write a deferred drop system, to pull cleaning up memory out of a latency-sensitive code path, using `dyn Drop` trait objects. However, this breaks down e.g. when `T` is `String`, which does not implement `Drop`, but should probably be accepted. To write a trait object bound that accepts anything, use a placeholder trait with a blanket implementation. ```rust trait Placeholder {} impl<T> Placeholder for T {} fn foo(_x: Box<dyn Placeholder>) {} ```
These are all testing corner-cases in the compiler. Adding a new warning broke these test cases, but --cap-lints stops it from actually breaking things in production.
notriddle
force-pushed
the
notriddle/drop-dyn
branch
from
20e1791 to
e054522
Compare
|
@bors r=varkor |
|
📌 Commit e054522 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the conversation in #86747.
Explanation
A trait object bound of the form
dyn Dropis most likely misleading and not what the programmer intended.Dropbounds do not actually indicate whether a type can be trivially dropped or not, because a composite type containingDroptypes does not necessarily implementDropitself. Naïvely, one might be tempted to write a deferred drop system, to pull cleaning up memory out of a latency-sensitive code path, usingdyn Droptrait objects. However, this breaks down e.g. whenTisString, which does not implementDrop, but should probably be accepted.To write a trait object bound that accepts anything, use a placeholder trait with a blanket implementation.