Finish portions of ifmt!
#8446
Closed
Finish portions of ifmt!
#8446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o/ |
|
By the way, I'm sure I've left out things which need to be documented, so if anyone wants some more explanation of what |
Currently the work just the same as the old `extfmt` versions
bors
added a commit
that referenced
this pull request
Aug 14, 2013
This includes a number of improvements to `ifmt!`
* Implements formatting arguments -- `{:0.5x}` works now
* Formatting now works on all integer widths, not just `int` and `uint`
* Added a large doc block to `std::fmt` which should help explain what `ifmt!` is all about
* Added floating point formatters, although they have the same pitfalls from before (they're just proof-of-concept now)
Closed a couple of issues along the way, yay! Once this gets into a snapshot, I'll start looking into removing all of `fmt`
| Because formatting is done via traits, there is no requirement that the | ||
| `d` format actually takes an `int`, but rather it simply requires a type which | ||
| ascribes to the `Signed` formatting trait. There are various parameters which do | ||
| require a particular type, however. Namely if the sytnax `{:.*s}` is used, then |
There was a problem hiding this comment.
"sytnax" should be "syntax".
There was a problem hiding this comment.
Hijacked #8485 to fix the typo, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a number of improvements to
ifmt!{:0.5x}works nowintanduintstd::fmtwhich should help explain whatifmt!is all aboutClosed a couple of issues along the way, yay! Once this gets into a snapshot, I'll start looking into removing all of
fmt