-
Notifications
You must be signed in to change notification settings - Fork 13.3k
use a SmallVec
in impl_or_trait_item
#83932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit b729815 with merge cf8fabe66a5f2f7ef7438c6b0e9810a0045b3c91... |
☀️ Try build successful - checks-actions |
Queued cf8fabe66a5f2f7ef7438c6b0e9810a0045b3c91 with parent 5c897d4, future comparison URL. |
Finished benchmarking try commit (cf8fabe66a5f2f7ef7438c6b0e9810a0045b3c91): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
No affect on instruction count, but max RSS looks a lot better :) |
@bors r+ |
📌 Commit b729815 has been approved by |
⌛ Testing commit b729815 with merge d8ecefe84897e3b844f3de3a018a7eff7fa605a3... |
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions |
#83293 showed that this is fairly hot, slightly improves max-rss and cpu cycles, does not noticeably improve instruction counts