Skip to content

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Nov 11, 2020

The last topic on #78433

I originally intended to place these tests in a single file, however, due to them being parser errors that are fatal, they must be in separate files to be detected.

Thanks, @lcnr for mentoring me on this PR.

r? @lcnr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 11, 2020
@lcnr lcnr added F-const_generics `#![feature(const_generics)]` F-min_const_generics labels Nov 12, 2020
@lcnr
Copy link
Contributor

lcnr commented Nov 12, 2020

thanks

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 12, 2020

📌 Commit 1d3f9d0 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2020
…ror, r=lcnr

Test default values for const parameters.

The last topic on rust-lang#78433

I originally intended to place these tests in a single file, however, due to them being parser errors that are fatal, they must be in separate files to be detected.

Thanks, `@lcnr` for mentoring me on this PR.

r? `@lcnr`
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2020
…laumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#78916 (extend const generics test suite)
 - rust-lang#78921 (Improve the page title switch handling between search and doc)
 - rust-lang#78933 (Don't print thread ids and names in `tracing` logs)
 - rust-lang#78960 (Test default values for const parameters.)
 - rust-lang#78971 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a2e9e3b into rust-lang:master Nov 12, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 12, 2020
@eopb eopb deleted the const-gen-test-default-error branch November 12, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-const_generics `#![feature(const_generics)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants