Skip to content

Minor cleanup around incremental compilation #78489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2020
Merged

Minor cleanup around incremental compilation #78489

merged 5 commits into from
Nov 3, 2020

Conversation

bugadani
Copy link
Contributor

  • Remove some short lived vectors
  • Fix some typos
  • Avoid some reallocations

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2020
@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2020
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 29, 2020

📌 Commit a8803d3 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2020
@bors
Copy link
Collaborator

bors commented Oct 30, 2020

⌛ Testing commit a8803d3 with merge a2cfafe820b415c3c3adea04eaea7980a48fc53e...

@bors
Copy link
Collaborator

bors commented Oct 30, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 30, 2020
@bugadani
Copy link
Contributor Author

I don't have experience with macOS - Does anyone know if this error was caused by my changes?

failures:

---- [debuginfo-lldb] debuginfo/pretty-std-collections.rs stdout ----
NOTE: compiletest thinks it is using LLDB version 1200
NOTE: compiletest thinks it is using LLDB without native rust support

error: Error while running LLDB
status: exit code: 1
command: "/usr/bin/python3" "/Users/runner/work/rust/rust/src/etc/lldb_batchmode.py" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/debuginfo/pretty-std-collections.lldb/a" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/debuginfo/pretty-std-collections.lldb/pretty-std-collections.debugger.script"
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
error: need to add support for DW_TAG_base_type '()' encoded with DW_ATE = 0x7, bit_size = 0
clang: CommandLine Error: Option 'h' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options

------------------------------------------



failures:
    [debuginfo-lldb] debuginfo/pretty-std-collections.rs

@bugadani bugadani mentioned this pull request Oct 31, 2020
Merged
@JohnTitor
Copy link
Member

It seems spurious.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2020
@JohnTitor JohnTitor mentioned this pull request Nov 2, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 3, 2020
@Dylan-DPC
Rollup merge of rust-lang#78489 - bugadani:array, r=estebank
01e7c01 
Minor cleanup around incremental compilation

* Remove some short lived vectors
* Fix some typos
* Avoid some reallocations
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 3, 2020
Closed
@bors
Copy link
Collaborator

bors commented Nov 3, 2020

⌛ Testing commit a8803d3 with merge 8e8939b...

@bors
Copy link
Collaborator

bors commented Nov 3, 2020

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 8e8939b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 3, 2020
@bors bors merged commit 8e8939b into rust-lang:master Nov 3, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 3, 2020
@bugadani bugadani deleted the array branch November 3, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bugadani @rust-highfive @estebank @bors @JohnTitor @jyn514 @rustbot