Make max_log_info easily greppable (for figuring out why debug logging is disabled)
#77701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
A-contributor-roadblock
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit a28f425 has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
the
T-bootstrap
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Oct 8, 2020
…crum Make `max_log_info` easily greppable (for figuring out why debug logging is disabled) Follow-up to rust-lang#77678 (comment). I'll make a PR to the dev-guide shortly changing `debug = true` to `debug-logging = true` and using this text. Ideally wouldn't be merged before rust-lang#77678, but it practice it won't hurt anything. r? @Mark-Simulacrum
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2020
…as-schievink Rollup of 8 pull requests Successful merges: - rust-lang#76750 (Don't discourage implementing `core::fmt::Write`) - rust-lang#77449 (BTreeMap: comment why drain_filter's size_hint is somewhat pessimistic) - rust-lang#77660 ((docs): make mutex error comment consistent with codebase) - rust-lang#77663 (Add compile fail test for issue 27675) - rust-lang#77673 (Remove unnecessary lamda on emitter map.) - rust-lang#77701 (Make `max_log_info` easily greppable (for figuring out why debug logging is disabled)) - rust-lang#77702 (Remove not needed lambda.) - rust-lang#77710 (Update submodule llvm to get LVI bugfix) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #77678 (comment). I'll make a PR to the dev-guide shortly changing
debug = truetodebug-logging = trueand using this text.Ideally wouldn't be merged before #77678, but it practice it won't hurt anything.
r? @Mark-Simulacrum