Use futex-based thread::park/unpark on Linux. #76919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
r? @dtolnay |
m-ou-se
force-pushed
the
thread-parker
branch
from
a2f2b42 to
fab849e
Compare
m-ou-se
changed the title
m-ou-se
force-pushed
the
thread-parker
branch
from
13ab12d to
d3984ce
Compare
Member
Author
|
Hm, looks like WaitOnAddress is only available on Windows 8+, but the Rust documentation promises tier 1 support for Windows 7+. Reverting the Windows part for now. |
m-ou-se
force-pushed
the
thread-parker
branch
from
d3984ce to
fab849e
Compare
m-ou-se
changed the title
m-ou-se
force-pushed
the
thread-parker
branch
from
7bceb2b to
8782bc1
Compare
Member
Author
|
@rustbot modify labels: +T-libs +A-concurrency +O-linux |
rustbot
added
A-concurrency
bjorn3
reviewed
Sep 26, 2020
bjorn3
reviewed
Sep 26, 2020
m-ou-se
force-pushed
the
thread-parker
branch
from
8782bc1 to
0b73fd7
Compare
Member
|
@bors r+ |
Collaborator
|
📌 Commit 0b73fd7 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Contributor
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 1, 2020
Tested on commit rust-lang/rust@7820135. Direct link to PR: <rust-lang/rust#76919> 💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
ghost
mentioned this pull request
63 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the parking/unparking logic out of
thread/mod.rsinto a module namedthread_parkerinsys_common. The current implementation is moved tosys_common/thread_parker/generic.rsand the new implementation using futexes is added insys_common/thread_parker/futex.rs.