rustdoc: Fix font CSS for crate lists #76453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire |
rustbot
added
C-bug
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
I had put it in the wrong file in rust-lang#76126. This should fix it now. Thank you to @ollie27 for pointing this out!
camelid
force-pushed
the
fix-css-crate-list
branch
from
26e0fce to
bf09a52
Compare
GuillaumeGomez
approved these changes
Sep 7, 2020
|
Thanks for fixing this so quickly. @bors r=GuillaumeGomez,ollie27 rollup |
|
📌 Commit bf09a52 has been approved by |
bors
added
S-waiting-on-bors
notriddle
reviewed
Sep 9, 2020
| @@ -126,6 +126,10 @@ h1, h2, h3, h4, | |||
| font-family: "Fira Sans", sans-serif; | |||
| } | |||
|
|
|||
| .content ul.crate a.crate { | |||
| font: 16px/1.6 "Fira Sans"; | |||
There was a problem hiding this comment.
Why doesn't this have a fallback font?
Suggested change
| font: 16px/1.6 "Fira Sans"; | |
| font: 16px/1.6 "Fira Sans", sans-serif; |
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had put it in the wrong file in #76126. This should fix it now. Thank
you to @ollie27 for pointing this out!
@rustbot modify labels: T-rustdoc C-bug