Improved some things in std::ascii #7199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed tests - Added methods - Renamed casting methods to be shorter closes rust-lang#7150
| @@ -96,8 +105,13 @@ impl<'self> AsciiCast<&'self[Ascii]> for &'self str { | |||
| #[inline(always)] | |||
| fn to_ascii(&self) -> &'self[Ascii] { | |||
| assert!(self.is_ascii()); | |||
| let (p,len): (*u8, uint) = unsafe{ cast::transmute(*self) }; | |||
| unsafe{ cast::transmute((p, len - 1))} | |||
There was a problem hiding this comment.
What's the point of len in these lines? Why isn't it necessary any more?
There was a problem hiding this comment.
It's still necessary, it just happens in the unsafe method below it. It's for adjusting the &str so that the last hidden byte it includes does not end up in the &[Ascii].
bors
added a commit
that referenced
this pull request
Jun 17, 2013
- Fixed tests - Added methods - Renamed casting methods to be shorter - Added unsafe versions Closes #7150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7150