Skip to content

Conversation

petrochenkov
Copy link
Contributor

MSVC is silly and doesn't recognize assert as diverging.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 6, 2020

📌 Commit 8e76663 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2020
…acrum

tests: Fix warnings in `rust_test_helpers.c`

MSVC is silly and doesn't recognize `assert` as diverging.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2020
…acrum

tests: Fix warnings in `rust_test_helpers.c`

MSVC is silly and doesn't recognize `assert` as diverging.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#71938 (Use trait_object_dummy_self instead of err)
 - rust-lang#71952 (Add some regression tests)
 - rust-lang#71959 (tests: Fix warnings in `rust_test_helpers.c`)
 - rust-lang#71962 (Grammar)
 - rust-lang#71972 (use hex for pointers in Miri error messages)
 - rust-lang#71980 (Allow a few warnings.)

Failed merges:

r? @ghost
@bors bors merged commit 9e4a745 into rust-lang:master May 7, 2020
@petrochenkov petrochenkov deleted the chelpers branch February 22, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants