Skip to content

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

estebank and others added 30 commits February 8, 2020 20:43
To avoid creating memsets with outdated signature. For some reason
SROA chokes on this when using NewPM.
nikic and others added 11 commits February 12, 2020 15:30
The new pass manager can be enabled using
-Z new-llvm-pass-manager=on.
Support new LLVM pass manager

Add support for the new LLVM pass manager behind a `-Z new-llvm-pass-manager=on` option. Both the pre-link optimization and LTO pipelines use the new pass manager. There's some bits that are not supported yet:

 * `-C passes`. NewPM requires an entirely different way of specifying custom pass pipelines. We should probably expose that functionality, but it doesn't directly map to what `-C passes` does.
 * NewPM has no support for custom inline parameters right now. We'd have to add upstream support for that first.
 * NewPM does not support PGO at O0 in LLVM 9 (which is why those tests fail with NewPM enabled). This is supported in LLVM 10.
 * NewPM does not support MergeFunctions in LLVM 9. I've landed this upstream just before the cut, so we'll be able to re-enable that with LLVM 10.

Closes rust-lang#64289.

r? @ghost
 Account for type params on method without parentheses

Account for those type parameters in the structured suggestion when forgetting to call method:

```
error[E0615]: attempted to take value of method `collect` on type `std::vec::IntoIter<_>`
  --> $DIR/method-missing-parentheses.rs:2:32
   |
LL |     let _ = vec![].into_iter().collect::<usize>;
   |                                ^^^^^^^---------
   |                                |
   |                                help: use parentheses to call the method: `collect::<usize>()`
```
…k,wesleywiser

miri: improve and simplify overflow detection

This simplifies the overflow detection for signed binary operators, and adds overflow detection to unary operators so that const-prop doesn't have to crudely hand-roll that.

It also fixes some bugs in the operator implementation that however, I think, were not observable.

r? @oli-obk @wesleywiser
Add initial debug fmt for Backtrace

Fixes the first point in rust-lang#65280

related to rust-lang#53487
…n-DPC

Update compiler-builtins to 0.1.25

- rust-lang/compiler-builtins#340 Set probestack visibility to hidden on ELF targets

Fixes rust-lang#68794.

Tested in CI: rust-lang#69045.

r? @Mark-Simulacrum
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented Feb 12, 2020

📌 Commit 839adda has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 12, 2020
@Dylan-DPC-zz Dylan-DPC-zz added the rollup A PR which is a rollup label Feb 12, 2020
@bors
Copy link
Collaborator

bors commented Feb 12, 2020

⌛ Testing commit 839adda with merge 92d8e82...

bors added a commit that referenced this pull request Feb 12, 2020
Rollup of 7 pull requests

Successful merges:

 - #67954 (Support new LLVM pass manager)
 - #68981 ( Account for type params on method without parentheses)
 - #69002 (miri: improve and simplify overflow detection)
 - #69038 (Add initial debug fmt for Backtrace)
 - #69040 (Cleanup SGX entry code)
 - #69086 (Update compiler-builtins to 0.1.25)
 - #69095 (Minified theme check)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Feb 13, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing 92d8e82 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 13, 2020
@bors bors merged commit 839adda into rust-lang:master Feb 13, 2020
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #69105!

Tested on commit 92d8e82.
Direct link to PR: #69105

💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 13, 2020
Tested on commit rust-lang/rust@92d8e82.
Direct link to PR: <rust-lang/rust#69105>

💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.