Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 2, 2019

This is a backport of #66338. There were some significant rendering regressions, particularly in example code, in the version on the beta branch.

This change drops mdbook-linkcheck rather than updating it. The new version brought in a number of new crates and changes that I wasn't comfortable pulling into beta. The linkcheck is only used for the rustc-guide which is not published from this repo.

Detailed notes are at https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Dec 2, 2019

📌 Commit 7b99e70 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2019
@alexcrichton
Copy link
Member

@bors: p=1

@bors
Copy link
Collaborator

bors commented Dec 2, 2019

⌛ Testing commit 7b99e70 with merge 3f4e08f...

bors added a commit that referenced this pull request Dec 2, 2019
[beta] Update mdbook

This is a backport of #66338. There were some significant rendering regressions, particularly in example code, in the version on the beta branch.

This change drops mdbook-linkcheck rather than updating it. The new version brought in a number of new crates and changes that I wasn't comfortable pulling into beta. The linkcheck is only used for the rustc-guide which is not published from this repo.

Detailed notes are at https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md
@bors
Copy link
Collaborator

bors commented Dec 2, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 3f4e08f to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 2, 2019
@bors bors merged commit 7b99e70 into rust-lang:beta Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants