Skip to content

More accurate spans, season 2 #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

More accurate spans, season 2 #6654

wants to merge 2 commits into from

Conversation

sanxiyn
Copy link
Contributor

@sanxiyn sanxiyn commented May 21, 2013

No description provided.

@sanxiyn
Copy link
Contributor Author

sanxiyn commented May 21, 2013

Given

use core::comm;
fn f(_x: &[int]) {}
fn main() {
    f(~[0]);
}

Before:

x.rs:1 use core::comm;
       ^~~~~~~~~~~~~~~
x.rs:4     f(~[0]);
             ^~~~~

After:

x.rs:1 use core::comm;
           ^~~~~~~~~~
x.rs:4     f(~[0]);
             ^~~~

bors added a commit that referenced this pull request May 21, 2013
@bors
auto merge of #6654 : sanxiyn/rust/accurate-span-2, r=bstrie
808aada
@bors bors closed this May 21, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 30, 2021
@bors
Auto merge of rust-lang#6654 - flip1995:no_lazy_static_regex, r=flip1995
95c0459 
No lazy static regex

r? `@llogiq`

rust-lang#6500

regex is unnecessary for this lint (rust-lang/rust-clippy#6500 (comment))
lazy_static is unnecessary. The std lazy feature should be  used instead.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanxiyn @bstrie @bors