miri panic_unwind: fix hack for SEH platforms #66466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit e8ff465 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=always |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 17, 2019
miri panic_unwind: fix hack for SEH platforms The old hack didn't work as we ended up duplicating the `eh_personality` lang item... I have no idea if rustc cares that `eh_catch_typeinfo` has a certain shape, but better safe than sorry. I cannot test this locally. r? @oli-obk Cc @Aaron1011
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 17, 2019
miri panic_unwind: fix hack for SEH platforms The old hack didn't work as we ended up duplicating the `eh_personality` lang item... I have no idea if rustc cares that `eh_catch_typeinfo` has a certain shape, but better safe than sorry. I cannot test this locally. r? @oli-obk Cc @Aaron1011
bors
added a commit
that referenced
this pull request
Nov 17, 2019
Rollup of 11 pull requests Successful merges: - #65739 (Improve documentation of `Vec::split_off(...)`) - #66271 (syntax: Keep string literals in ABIs and `asm!` more precisely) - #66344 (rustc_plugin: Remove `Registry::register_attribute`) - #66381 (find_deprecation: deprecation attr may be ill-formed meta.) - #66395 (Centralize panic macro documentation) - #66456 (Move `DIAGNOSTICS` usage to `rustc_driver`) - #66465 (add missing 'static lifetime in docs) - #66466 (miri panic_unwind: fix hack for SEH platforms) - #66469 (Use "field is never read" instead of "field is never used") - #66471 (Add test for issue 63116) - #66477 (Clarify transmute_copy documentation example) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old hack didn't work as we ended up duplicating the
eh_personalitylang item...I have no idea if rustc cares that
eh_catch_typeinfohas a certain shape, but better safe than sorry. I cannot test this locally.r? @oli-obk Cc @Aaron1011