Skip to content

Don't use an allocation for ItemId in StmtKind #58528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2019
Merged

Don't use an allocation for ItemId in StmtKind #58528

merged 1 commit into from
Feb 20, 2019

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Feb 17, 2019

No description provided.

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Feb 17, 2019

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 17, 2019

📌 Commit cdd1c0e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2019
@Mark-Simulacrum
Copy link
Member

@bors r-

We should not be landing this without support for why we're doing it - at least a perf run.

Cc @nnethercote

@bors try

@bors
Copy link
Collaborator

bors commented Feb 17, 2019

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2019
@nnethercote
Copy link
Contributor

This looks fine to me. I expect it will either have no noticeable effect or be a small improvement. Either way it's still worth landing for the code simplification.

@bors try

@bors
Copy link
Collaborator

bors commented Feb 17, 2019

⌛ Trying commit cdd1c0e with merge d18f9b6ebce5710fd5379932994af11a2622836a...

@bors
Copy link
Collaborator

bors commented Feb 18, 2019

☀️ Test successful - checks-travis
State: approved= try=True

@nnethercote
Copy link
Contributor

@rust-timer build d18f9b6ebce5710fd5379932994af11a2622836a

@rust-timer
Copy link
Collaborator

Success: Queued d18f9b6ebce5710fd5379932994af11a2622836a with parent 9a3392e, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit d18f9b6ebce5710fd5379932994af11a2622836a

@nnethercote
Copy link
Contributor

nnethercote commented Feb 18, 2019 •
edited
Loading

Perf results look like noise, no discernible perf effect.

@bors r=oli-obk rollup

@bors
Copy link
Collaborator

bors commented Feb 18, 2019

📌 Commit cdd1c0e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2019
@bors
Copy link
Collaborator

bors commented Feb 18, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Feb 18, 2019

📌 Commit cdd1c0e has been approved by oli-obk

kennytm added a commit to kennytm/rust that referenced this pull request Feb 18, 2019
@kennytm
Rollup merge of rust-lang#58528 - Zoxc:stmtkind-item, r=oli-obk
2eaf3bd 
Don't use an allocation for ItemId in StmtKind
@kennytm kennytm mentioned this pull request Feb 18, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Feb 18, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#58528 - Zoxc:stmtkind-item, r=oli-obk
2b85431 
Don't use an allocation for ItemId in StmtKind
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 18, 2019
Closed
@kennytm kennytm mentioned this pull request Feb 19, 2019
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Feb 20, 2019
@kennytm
Rollup merge of rust-lang#58528 - Zoxc:stmtkind-item, r=oli-obk
e95297c 
Don't use an allocation for ItemId in StmtKind
bors added a commit that referenced this pull request Feb 20, 2019
@bors
Auto merge of #58578 - kennytm:rollup, r=kennytm
ff5dc27 
Rollup of 24 pull requests

Successful merges:

 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58044 (Make overflowing and wrapping negation const)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58384 (Fix tables display)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58409 (rustdoc: respect alternate flag when formatting impl trait)
 - #58456 (Remove no longer accurate diagnostic code about NLL)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58538 (Add missing fmt structs examples)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58546 (librustc_codegen_llvm => 2018)
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind)
 - #58553 (Use more impl header lifetime elision)
 - #58562 (Fix style nits)
 - #58565 (Fix typo in std::future::Future docs)
 - #58568 (Fix a transposition in driver.rs.)
 - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
 - #58576 (Stabilize iter::successors and iter::from_fn)
bors added a commit that referenced this pull request Feb 20, 2019
@bors
Auto merge of #58578 - kennytm:rollup, r=kennytm
f66e469 
Rollup of 24 pull requests

Successful merges:

 - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
 - #58044 (Make overflowing and wrapping negation const)
 - #58303 (Improve stability tags display)
 - #58336 (Fix search results interactions)
 - #58384 (Fix tables display)
 - #58392 (Use less explicit shifting in std::net::ip)
 - #58409 (rustdoc: respect alternate flag when formatting impl trait)
 - #58456 (Remove no longer accurate diagnostic code about NLL)
 - #58528 (Don't use an allocation for ItemId in StmtKind)
 - #58530 (Monomorphize less code in fs::{read|write})
 - #58534 (Mention capping forbid lints)
 - #58536 (Remove UB in pointer tests)
 - #58538 (Add missing fmt structs examples)
 - #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
 - #58544 (Fix doc for rustc "-g" flag)
 - #58545 (Add regression test for a specialization-related ICE (#39448))
 - #58546 (librustc_codegen_llvm => 2018)
 - #58551 (Explain a panic in test case net::tcp::tests::double_bind)
 - #58553 (Use more impl header lifetime elision)
 - #58562 (Fix style nits)
 - #58565 (Fix typo in std::future::Future docs)
 - #58568 (Fix a transposition in driver.rs.)
 - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
 - #58576 (Stabilize iter::successors and iter::from_fn)
@bors bors merged commit cdd1c0e into rust-lang:master Feb 20, 2019
@Zoxc Zoxc deleted the stmtkind-item branch February 20, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zoxc @rust-highfive @oli-obk @bors @Mark-Simulacrum @nnethercote @rust-timer