Skip to content

Fix right arrow size for crate filter #56633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2018
Merged

Fix right arrow size for crate filter #56633

merged 1 commit into from
Dec 11, 2018

Conversation

GuillaumeGomez
Copy link
Member

This bug only appears when a crate has a long name:

screenshot 2018-12-08 at 16 36 21

With this fix, it goes back to normal, whatever the size:

screenshot 2018-12-08 at 16 36 05

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2018
@QuietMisdreavus
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 10, 2018

📌 Commit bbc2654 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 10, 2018
@GuillaumeGomez
Rollup merge of rust-lang#56633 - GuillaumeGomez:fix-right-arrow-disp…
33bf291 
…lay, r=QuietMisdreavus

Fix right arrow size for crate filter

This bug only appears when a crate has a long name:

<img width="1440" alt="screenshot 2018-12-08 at 16 36 21" src="https://user-images.githubusercontent.com/3050060/49687728-7de06180-fb07-11e8-8554-d32597351fac.png">

With this fix, it goes back to normal, whatever the size:

<img width="1440" alt="screenshot 2018-12-08 at 16 36 05" src="https://user-images.githubusercontent.com/3050060/49687730-8769c980-fb07-11e8-91b7-b5e1961211a2.png">

r? @QuietMisdreavus
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 10, 2018
Merged
bors added a commit that referenced this pull request Dec 10, 2018
@bors
Auto merge of #56688 - GuillaumeGomez:rollup, r=GuillaumeGomez
da1527c 
Rollup of 5 pull requests

Successful merges:

 - #56491 (emit error with span for empty asserts)
 - #56633 (Fix right arrow size for crate filter)
 - #56641 (fix span for invalid number of parameters in trait method)
 - #56656 (Fix typo)
 - #56661 (Add regression test for ICE)

Failed merges:

r? @ghost
@bors bors merged commit bbc2654 into rust-lang:master Dec 11, 2018
@GuillaumeGomez GuillaumeGomez deleted the fix-right-arrow-display branch December 11, 2018 08:58
@SimonSapin SimonSapin mentioned this pull request Dec 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@QuietMisdreavus QuietMisdreavus QuietMisdreavus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @rust-highfive