Skip to content

Fix internal compiler error on malformed match arm pattern. #54893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3866,6 +3866,9 @@ impl<'a> Parser<'a> {
// check that a comma comes after every field
if !ate_comma {
let err = self.struct_span_err(self.prev_span, "expected `,`");
if let Some(mut delayed) = delayed_err {
delayed.emit();
}
return Err(err);
}
ate_comma = false;
Expand Down
21 changes: 21 additions & 0 deletions src/test/ui/resolve/issue-54379.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
struct MyStruct {
pub s1: Option<String>,
}

fn main() {
let thing = MyStruct { s1: None };

match thing {
MyStruct { .., Some(_) } => {},
_ => {}
}
}
24 changes: 24 additions & 0 deletions src/test/ui/resolve/issue-54379.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
error: expected `}`, found `,`
--> $DIR/issue-54379.rs:18:22
|
LL | MyStruct { .., Some(_) } => {},
| --^
| | |
| | expected `}`
| `..` must be at the end and cannot have a trailing comma

error: expected `,`
--> $DIR/issue-54379.rs:18:24
|
LL | MyStruct { .., Some(_) } => {},
| ^^^^

error[E0027]: pattern does not mention field `s1`
--> $DIR/issue-54379.rs:18:9
|
LL | MyStruct { .., Some(_) } => {},
| ^^^^^^^^^^^^^^^^^^^^^^^^ missing field `s1`

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0027`.