Skip to content

submodules: update clippy to 22d37b53af5b to fix tests. #54854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2018
Merged

submodules: update clippy to 22d37b53af5b to fix tests. #54854

merged 1 commit into from
Oct 6, 2018

Conversation

matthiaskrgr
Copy link
Member

Should fix clippy toolstate.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2018
@matthiaskrgr matthiaskrgr changed the title submodules: update clippy to 87f6d9e7f94af1e2c192a68c997e6b247bba5d06 to fix tests. [HOLD] submodules: update clippy to 87f6d9e7f94af1e2c192a68c997e6b247bba5d06 to fix tests. Oct 5, 2018
@matthiaskrgr
Copy link
Member Author

todo: needs to include rust-lang/rust-clippy#3270 once that is merged

@Manishearth
Copy link
Member

It's merged

@matthiaskrgr matthiaskrgr changed the title [HOLD] submodules: update clippy to 87f6d9e7f94af1e2c192a68c997e6b247bba5d06 to fix tests. submodules: update clippy to 22d37b53af5b to fix tests. Oct 6, 2018
@matthiaskrgr
Copy link
Member Author

Thanks, updated.

@Manishearth
Copy link
Member

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Oct 6, 2018

📌 Commit 22d37b5 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2018
@bors
Copy link
Collaborator

bors commented Oct 6, 2018

⌛ Testing commit 22d37b5 with merge 7ec50f4...

bors added a commit that referenced this pull request Oct 6, 2018
@bors
Auto merge of #54854 - matthiaskrgr:clippy_update, r=Manishearth
7ec50f4 
 submodules: update clippy to 22d37b5 to fix tests.

Should fix clippy toolstate.
@bors
Copy link
Collaborator

bors commented Oct 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Manishearth
Pushing 7ec50f4 to master...

@bors bors merged commit 22d37b5 into rust-lang:master Oct 6, 2018
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #54854!

Tested on commit 7ec50f4.
Direct link to PR: #54854

🎉 clippy-driver on windows: test-fail → test-pass.
🎉 clippy-driver on linux: test-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 6, 2018
@rust-highfive
📣 Toolstate changed by rust-lang/rust#54854!
e6f173f 
Tested on commit rust-lang/rust@7ec50f4.
Direct link to PR: <rust-lang/rust#54854>

🎉 clippy-driver on windows: test-fail → test-pass.
🎉 clippy-driver on linux: test-fail → test-pass.
@matthiaskrgr matthiaskrgr deleted the clippy_update branch October 15, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @rust-highfive @Manishearth @bors @aturon