Self in type definitions (self_in_typedefs)
#53324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Aug 14, 2018
eddyb
reviewed
Aug 14, 2018
eddyb
reviewed
Aug 14, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Err, is tidy broken here? That line definitely isn't longer than 100 chars. |
|
@alexreg: I'm not sure about the 100 character message, but there's an issue with the diagnostic length: |
|
@varkor Yeah, I noticed that after I posted the above, but thanks! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
varkor
reviewed
Aug 15, 2018
estebank
reviewed
Aug 15, 2018
This comment has been minimized.
This comment has been minimized.
|
@Centril Turns out having this feature for |
|
@alexreg leave it out ;) |
|
All should be in order now! Ready for a review, @eddyb. |
Centril
reviewed
Aug 15, 2018
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
varkor
reviewed
Aug 15, 2018
src/doc/unstable-book/src/language-features/self-in-typedefs.md
Outdated
Show resolved
Hide resolved
varkor
reviewed
Aug 15, 2018
eddyb
reviewed
Aug 18, 2018
| @@ -2968,7 +2990,12 @@ impl<'a, 'crateloader: 'a> Resolver<'a, 'crateloader> { | |||
| if is_self_type(path, ns) { | |||
| __diagnostic_used!(E0411); | |||
| err.code(DiagnosticId::Error("E0411".into())); | |||
| err.span_label(span, "`Self` is only available in traits and impls"); | |||
| let available_in = if this.session.features_untracked().self_in_typedefs { | |||
| "impls, traits, and type definitions" | |||
There was a problem hiding this comment.
The order here changed, is that intentional?
There was a problem hiding this comment.
Yes, it is. I had accidentally deleted it before and rewritten it the wrong way round, which broke some UI tests. :-P So this fixes it.
added 3 commits
August 18, 2018 18:54
Currently type definitions include `struct`, `enum`, `union`, `existential type`.
eddyb
approved these changes
Aug 18, 2018
|
@bors r+ |
|
📌 Commit 4e7d3f5 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 18, 2018
`Self` in type definitions (self_in_typedefs) This implements the [`self_in_typedefs` feature](https://github.com/rust-lang/rfcs/blob/master/text/2300-self-in-typedefs.md) ([tracking issue 49303](#49303)). r? @eddyb CC @Centril
|
☀️ Test successful - status-appveyor, status-travis |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
self_in_typedefsfeature (tracking issue 49303).r? @eddyb
CC @Centril