Skip to content

Haiku: set stack size to 16 MB on Haiku, use 32 MB on other platforms #51756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2018
Merged

Haiku: set stack size to 16 MB on Haiku, use 32 MB on other platforms #51756

merged 1 commit into from
Jun 26, 2018

Conversation

nielx
Copy link
Contributor

@nielx nielx commented Jun 24, 2018

The maximum stack size on Haiku is set to 16 MB (see the Haiku source). With this change rustdoc will also work on Haiku.

@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2018
@GuillaumeGomez
Copy link
Member

Instead of a runtime condition, you could have used conditional compilation but I don't think it matters much. :)

@bors: r+

@bors
Copy link
Collaborator

bors commented Jun 24, 2018

📌 Commit b70305f has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2018
@bors
Copy link
Collaborator

bors commented Jun 24, 2018

⌛ Testing commit b70305f with merge ab4b57c65348fba8f1668b1af15f24ceb28ab25e...

@bors
Copy link
Collaborator

bors commented Jun 24, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2018
@rust-highfive
Copy link
Contributor

The job mingw-check of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:05f331b6:start=1529841447128049976,finish=1529841447132415525,duration=4365549
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1c337e74
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:355418d0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

The job mingw-check of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:05f331b6:start=1529841447128049976,finish=1529841447132415525,duration=4365549
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1c337e74
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:355418d0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nielx
Copy link
Contributor Author

nielx commented Jun 24, 2018

@bors retry

@bors
Copy link
Collaborator

bors commented Jun 24, 2018

@nielx: 🔑 Insufficient privileges: not in try users

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2018
@bors
Copy link
Collaborator

bors commented Jun 24, 2018

⌛ Testing commit b70305f with merge ae326041e5ebde51831286dee44b3c3403b83976...

@bors
Copy link
Collaborator

bors commented Jun 24, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2018
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-debug of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:0d8ce13c:start=1529845057439583051,finish=1529845057447967260,duration=8384209
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0dac8860
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0f57325b
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-debug of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:0d8ce13c:start=1529845057439583051,finish=1529845057447967260,duration=8384209
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0dac8860
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0f57325b
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@GuillaumeGomez
Copy link
Member

It won't work until crates.io works again.

@pietroalbini
Copy link
Member

@bors retry (crates.io outage)

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 24, 2018
@bors
Copy link
Collaborator

bors commented Jun 24, 2018

⌛ Testing commit b70305f with merge 367990109a005481335dcfa5ac5ccd490b16155f...

@bors
Copy link
Collaborator

bors commented Jun 24, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2018
@rust-highfive
Copy link
Contributor

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:00:52] sha256:dc365898ae0130338f4ac4e5ddd8d3b248c287c6baa3ba22c0314117d4c95534
[00:00:52] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/armhf-gnu/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:52] Sending build context to Docker daemon  501.2kB
[00:00:52] Step 1/20 : FROM ubuntu:16.04
[00:00:52] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:53] Sending build context to Docker daemon  501.2kB
[00:00:53] Step 1/20 : FROM ubuntu:16.04
[00:00:53] Step 1/20 : FROM ubuntu:16.04
[00:00:53] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:56] Sending build context to Docker daemon  501.2kB
[00:00:56] Step 1/20 : FROM ubuntu:16.04
[00:00:56] Step 1/20 : FROM ubuntu:16.04
[00:00:56] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:59] Sending build context to Docker daemon  501.2kB
[00:00:59] Step 1/20 : FROM ubuntu:16.04
[00:00:59] Step 1/20 : FROM ubuntu:16.04
[00:00:59] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:03] Sending build context to Docker daemon  501.2kB
[00:01:03] Step 1/20 : FROM ubuntu:16.04
[00:01:03] Step 1/20 : FROM ubuntu:16.04
[00:01:03] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:03] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:19a5c478
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:1aa6364b:start=1529878389398375000,finish=1529878389405505544,duration=7130544
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:03ca418d
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0aa7fcf9
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:00:52] sha256:dc365898ae0130338f4ac4e5ddd8d3b248c287c6baa3ba22c0314117d4c95534
[00:00:52] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/armhf-gnu/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:52] Sending build context to Docker daemon  501.2kB
[00:00:52] Step 1/20 : FROM ubuntu:16.04
[00:00:52] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:53] Sending build context to Docker daemon  501.2kB
[00:00:53] Step 1/20 : FROM ubuntu:16.04
[00:00:53] Step 1/20 : FROM ubuntu:16.04
[00:00:53] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:56] Sending build context to Docker daemon  501.2kB
[00:00:56] Step 1/20 : FROM ubuntu:16.04
[00:00:56] Step 1/20 : FROM ubuntu:16.04
[00:00:56] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:59] Sending build context to Docker daemon  501.2kB
[00:00:59] Step 1/20 : FROM ubuntu:16.04
[00:00:59] Step 1/20 : FROM ubuntu:16.04
[00:00:59] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:03] Sending build context to Docker daemon  501.2kB
[00:01:03] Step 1/20 : FROM ubuntu:16.04
[00:01:03] Step 1/20 : FROM ubuntu:16.04
[00:01:03] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:01:03] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:19a5c478
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:1aa6364b:start=1529878389398375000,finish=1529878389405505544,duration=7130544
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:03ca418d
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0aa7fcf9
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nielx
Copy link
Contributor Author

nielx commented Jun 25, 2018

We seem to be out of luck with CI this weekend, now docker.io is acting up.

@kennytm
Copy link
Member

kennytm commented Jun 25, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2018
@bors
Copy link
Collaborator

bors commented Jun 26, 2018

⌛ Testing commit b70305f with merge 9cc3d44...

bors added a commit that referenced this pull request Jun 26, 2018
@bors
Auto merge of #51756 - nielx:fix/librustdoc, r=GuillaumeGomez
9cc3d44 
Haiku: set stack size to 16 MB on Haiku, use 32 MB on other platforms

The maximum stack size on Haiku is set to 16 MB (see [the Haiku source](https://git.haiku-os.org/haiku/tree/headers/private/system/thread_defs.h#n17)). With this change rustdoc will also work on Haiku.
@bors
Copy link
Collaborator

bors commented Jun 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 9cc3d44 to master...

@bors bors merged commit b70305f into rust-lang:master Jun 26, 2018
@nielx nielx deleted the fix/librustdoc branch June 28, 2018 07:50
@workingjubilee workingjubilee added the O-haiku Target: Be extant; from mouldering old leaves; spring arrives again label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
O-haiku Target: Be extant; from mouldering old leaves; spring arrives again S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nielx @rust-highfive @GuillaumeGomez @bors @Mark-Simulacrum @pietroalbini @kennytm @workingjubilee