Ignore functions before main and thread entry points in backtraces #49825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Zoxc
commented
Apr 15, 2018
| f() | ||
| fn mark_start(f: &mut FnMut()) { | ||
| f(); | ||
| #[cfg(not(target_arch = "asmjs"))] |
There was a problem hiding this comment.
This now just excludes asmjs from the changes.
|
Ping from triage @alexcrichton! This PR needs your review. |
|
Sorry for taking awhile to get to this, but can this include a test of some form to ensure it works across platforms and doesn't regress? |
Closed
pietroalbini
added
S-waiting-on-author
|
Ping from triage @Zoxc! The reviewer asked for some changes. |
|
Closing due to inactivity, feel free to re-open or submit a new PR in the future. Thanks for your changes! |
TimNN
added
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same PR as #47824