syntax: Make imports in AST closer to the source and cleanup their parsing #48917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #48691) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Could someone else from @rust-lang/compiler take this over? This touches a lot of code that I know little about. |
oli-obk
approved these changes
Mar 12, 2018
src/libsyntax/ast.rs
Outdated
| @@ -1880,18 +1880,29 @@ pub type Variant = Spanned<Variant_>; | |||
|
|
|||
| #[derive(Clone, PartialEq, Eq, RustcEncodable, RustcDecodable, Hash, Debug)] | |||
| pub enum UseTreeKind { | |||
|
@bors r=oli-obk |
|
📌 Commit 6150b1b has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #48811) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
@bors r=oli-obk |
|
📌 Commit 57ddaae has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 57ddaae719544aac2384bce9ee8471bbe49ae124 with merge 79348e6ce42fda50f745553dba8babf5a92b83a9... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
Fix `unused_import_braces` lint false positive on `use prefix::{self as rename}`
…bilities Add the root segment for name resolution purposes only
|
@bors r=oli-obk |
|
📌 Commit a02b1d7 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 18, 2018
syntax: Make imports in AST closer to the source and cleanup their parsing This is a continuation of #45846 in some sense.
|
☀️ Test successful - status-appveyor, status-travis |
kennytm-githubbot
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Mar 18, 2018
Tested on commit rust-lang/rust@5e3ecdc. Direct link to PR: <rust-lang/rust#48917> 💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk). 💔 clippy-driver on linux: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #45846 in some sense.