Skip to content

Conversation

spastorino
Copy link
Member

Follow up of #47604 & #47605
r? @nikomatsakis

Let's see what CI says /cc @nikomatsakis & @totorigolo

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2018
@spastorino
Copy link
Member Author

There's something wrong in the PR.

The PR is running ui/invalid-module-declaration/auxiliary/foo/bar.rs and ui/invalid-module-declaration/auxiliary/foo/mod.rs as tests and they are not. This is probably easy fixable.

But from my test run in my local machine I also see compile-fail/coherence-cow.rs failing. Unsure about this one, haven't investigated.

@totorigolo I think this was what I was seeing in my previous PR. If you want to investigate all this please go ahead. Meanwhile, I guess, this can be closed again. I guess after having the CI run so we can get rid of all the doubts we had.

@nikomatsakis
Copy link
Contributor

@spastorino if you are not actively hacking on this, I'm inclined to close it for now; @topecongiro can re-open?

@spastorino
Copy link
Member Author

@nikomatsakis 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants