Skip to content

Document that Index ops can panic on HashMap & BTreeMap. #47839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2018
Merged

Document that Index ops can panic on HashMap & BTreeMap. #47839

merged 1 commit into from
Jan 30, 2018

Conversation

@frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Jan 29, 2018

Fixes #47011.

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 29, 2018

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Jan 29, 2018

r? @QuietMisdreavus

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2018
@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Jan 29, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 29, 2018

📌 Commit 7b4cbbd has been approved by QuietMisdreavus

kennytm added a commit to kennytm/rust that referenced this pull request Jan 29, 2018
@kennytm
Rollup merge of rust-lang#47839 - frewsxcv:frewsxcv-map-index, r=Quie…
c4b1ee5 
…tMisdreavus

Document that `Index` ops can panic on `HashMap` & `BTreeMap`.

Fixes rust-lang#47011.
@kennytm kennytm mentioned this pull request Jan 29, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Jan 30, 2018
@kennytm
Rollup merge of rust-lang#47839 - frewsxcv:frewsxcv-map-index, r=Quie…
95572df 
…tMisdreavus

Document that `Index` ops can panic on `HashMap` & `BTreeMap`.

Fixes rust-lang#47011.
@kennytm kennytm mentioned this pull request Jan 30, 2018
Merged
bors added a commit that referenced this pull request Jan 30, 2018
@bors
Auto merge of #47870 - kennytm:rollup, r=kennytm
def3269 
Rollup of 12 pull requests

- Successful merges: #47515, #47603, #47718, #47732, #47760, #47780, #47822, #47826, #47836, #47839, #47853, #47855
- Failed merges:
@bors bors merged commit 7b4cbbd into rust-lang:master Jan 30, 2018
@frewsxcv frewsxcv deleted the frewsxcv-map-index branch January 30, 2018 17:30
@fmdkdd fmdkdd mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@QuietMisdreavus QuietMisdreavus

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@frewsxcv @rust-highfive @QuietMisdreavus @bors @kennytm @shepmaster