Clarify where is_import is used
#47095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it's not mistaken for dead code.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
reviewed
Dec 31, 2017
| @@ -132,6 +132,7 @@ pub struct Export { | |||
| /// We include non-`pub` exports for hygienic macros that get used from extern crates. | |||
| pub vis: ty::Visibility, | |||
| /// True if from a `use` or and `extern crate`. | |||
| /// Used in rustdoc. | |||
| pub is_import: bool, | |||
There was a problem hiding this comment.
Can't this be checked by way of tcx.def_key(export.def.def_id()).parent? Or by adding a DefId of the export itself, and comparing that to export.def.def_id().
There was a problem hiding this comment.
Yeah, this should be removable with a little refactoring in rustdoc, opened #47100.
kennytm
added
the
S-waiting-on-review
|
cc @jseyfried who added |
|
@bors r+ rollup |
|
📌 Commit f6ff377 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 1, 2018
Clarify where `is_import` is used So it's not mistaken for dead code.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it's not mistaken for dead code.