Skip to content

Remove dead field is_import from Export. #47092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

leoyvens
Copy link
Contributor

It's dead code afaict.

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm
Copy link
Member

kennytm commented Dec 31, 2017

Apparently not dead.

[00:35:31] error[E0609]: no field `is_import` on type `&rustc::hir::def::Export`
[00:35:31]   --> /checkout/src/librustdoc/visit_lib.rs:71:22
[00:35:31]    |
[00:35:31] 71 |             if !item.is_import || item.vis == Visibility::Public {
[00:35:31]    |                      ^^^^^^^^^
[00:35:31] 
[00:35:31] error: aborting due to previous error
[00:35:31] 
[00:35:31] error: Could not compile `rustdoc`.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2017
@leoyvens
Copy link
Contributor Author

@kennytm Indeed, closing in favour of #47095.

@leoyvens leoyvens closed this Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants