Skip to content

rustc_trans: Fix indentation in trans_set_discr. #46624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2017
Merged

rustc_trans: Fix indentation in trans_set_discr. #46624

merged 1 commit into from
Dec 11, 2017

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Dec 10, 2017

Just noticed this while reading through #46521, which introduced this weird
alignment.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm
Copy link
Member

kennytm commented Dec 10, 2017 •
edited
Loading

By "alignment" you mean "code indentation"? The former has a quite different meaning in the context of the compiler 😄

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 10, 2017
@emilio
rustc_trans: Fix indentation in trans_set_discr.
2fe2488 
Just noticed this while reading through rust-lang#46521, which introduced this weird
alignment.
@emilio
Copy link
Contributor Author

emilio commented Dec 10, 2017

Fair enough, ammended :)

@emilio emilio changed the title rustc_trans: Fix alignment of trans_set_discr. rustc_trans: Fix indentation in trans_set_discr. Dec 10, 2017
@kennytm
Copy link
Member

kennytm commented Dec 10, 2017

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 10, 2017

📌 Commit 2fe2488 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2017
@bors
Copy link
Collaborator

bors commented Dec 11, 2017

⌛ Testing commit 2fe2488 with merge 830599b...

bors added a commit that referenced this pull request Dec 11, 2017
@bors
Auto merge of #46624 - emilio:nit, r=kennytm
830599b 
rustc_trans: Fix indentation in trans_set_discr.

Just noticed this while reading through #46521, which introduced this weird
alignment.
@bors
Copy link
Collaborator

bors commented Dec 11, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 830599b to master...

@bors bors merged commit 2fe2488 into rust-lang:master Dec 11, 2017
@emilio emilio deleted the nit branch January 8, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emilio @rust-highfive @kennytm @bors @pnkfelix