more work on container traits #4571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Where is the segfault happening? |
Contributor
Author
|
@catamorphism: It seems like there was just some problem with my build of LLVM - removing the |
Contributor
|
Looks great, thanks! |
catamorphism
added a commit
that referenced
this pull request
Jan 22, 2013
more work on container traits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the container module from just
Setto the following:Container->Mutable-> {Map,Set}The
Maptrait is implemented byTreeMapandLinearMapto replace to never implementedSendMaptrait. It's incomplete at the moment (missingfindfor now - need to breakLinearMap's API and update users of it) andTreeMapwill need to be extended to supportpop,getandconsumeto get rid of theLinearMapanonymous implementation. I think I'll drop the currentfindandgetonLinearMapbecause they don't offer anything over doing the copy in the caller.Currently causes a segfault in stage1... not sure what to do about that (core.rc and std.rc compile okay with rustc from incoming).