Skip to content

Reflect on char as u32, not uint (which may be u64). #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2013
Merged

Reflect on char as u32, not uint (which may be u64). #4477

merged 1 commit into from
Jan 14, 2013

Conversation

jld
Copy link
Contributor

@jld jld commented Jan 14, 2013

Fixes #4473.

brson added a commit that referenced this pull request Jan 14, 2013
@brson
Merge pull request #4477 from jld/char-repr
0e84907 
Reflect on char as u32, not uint (which may be u64).
@brson brson merged commit 0e84907 into rust-lang:incoming Jan 14, 2013
@brson
Copy link
Contributor

brson commented Jan 14, 2013

Thanks!

@graydon
Copy link
Contributor

graydon commented Jan 15, 2013

Huh. Feels like it should write char, no? Like that the %? formatter should actually output a char literal -- perhaps escaped, as we would a string -- not a formatted number?

@SimonSapin SimonSapin mentioned this pull request Jan 20, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jld @brson @graydon