Skip to content

Fix some unaligned reads on SPARC in LTO #43615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2017

Conversation

dhduvall
Copy link

@dhduvall dhduvall commented Aug 2, 2017

This fixes #43593 by eliminating some undefined behavior.

This fixes rust-lang#43593 by eliminating some undefined behavior.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aidanhs
Copy link
Member

aidanhs commented Aug 3, 2017

Thanks for the PR @dhduvall! We'll check in now and again to make sure @pnkfelix or another reviewer gets to this soon.

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2017
@nagisa
Copy link
Member

nagisa commented Aug 4, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 4, 2017

📌 Commit e412cb3 has been approved by nagisa

@nagisa
Copy link
Member

nagisa commented Aug 4, 2017

Thanks for the fix!

@bors
Copy link
Collaborator

bors commented Aug 4, 2017

⌛ Testing commit e412cb3 with merge 9b6c238...

bors added a commit that referenced this pull request Aug 4, 2017
Fix some unaligned reads on SPARC in LTO

This fixes #43593 by eliminating some undefined behavior.
@bors
Copy link
Collaborator

bors commented Aug 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing 9b6c238 to master...

@bors bors merged commit e412cb3 into rust-lang:master Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPARC alignment issue in LTO
6 participants