Skip to content

Move global vars changing tests into run-pass #42884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2017
Merged

Move global vars changing tests into run-pass #42884

merged 1 commit into from
Jun 29, 2017

Conversation

stepancheg
Copy link
Contributor

Should fix race #42795

@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@stepancheg
Copy link
Contributor Author

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jun 24, 2017

📌 Commit 45af6ee has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 24, 2017

⌛ Testing commit 45af6ee with merge f62cae43700e171de4fd6add2702b62b67440c8c...

@bors
Copy link
Collaborator

bors commented Jun 24, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

@bors retry

os x timed out

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 24, 2017
@Mark-Simulacrum
Copy link
Member

@bors retry

Trying to get bors to recognize world state...

@bors
Copy link
Collaborator

bors commented Jun 26, 2017

⌛ Testing commit 45af6ee with merge 0254fde8fcb438adf9ea40df42b25b7a17764e60...

@bors
Copy link
Collaborator

bors commented Jun 26, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Jun 26, 2017

macOS (64-bit dist) stuck when compiling stage0-rustc, spurious.

[01:35:28]    Compiling proc_macro v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libproc_macro)
[01:35:58]    Compiling rustc_const_math v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_const_math)
[01:36:05]    Compiling syntax_ext v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libsyntax_ext)
[01:36:39]    Compiling rustc v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc)

No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.

@alexcrichton
Copy link
Member

@bors: retry

@carols10cents
Copy link
Member

@bors retry

umm 1 osx builder timed out (red) 4 were terminated (gray)?

@kennytm
Copy link
Member

kennytm commented Jun 26, 2017 •
edited
Loading

@carols10cents If any job in the build completed abnormally, all other running jobs will be canceled so another PR can start immediately.

@arielb1
Copy link
Contributor

arielb1 commented Jun 29, 2017

@bors rollup

arielb1 pushed a commit to arielb1/rust that referenced this pull request Jun 29, 2017
Rollup merge of rust-lang#42884 - stepancheg:set-env-run-pass, r=alex…
4bae0d8 
…crichton

Move global vars changing tests into run-pass

Should fix race rust-lang#42795
@arielb1 arielb1 mentioned this pull request Jun 29, 2017
Merged
bors added a commit that referenced this pull request Jun 29, 2017
@bors
Auto merge of #42964 - arielb1:rollup, r=arielb1
7acce37 
Rollup of 12 pull requests

- Successful merges: #42219, #42831, #42832, #42884, #42886, #42901, #42919, #42920, #42946, #42953, #42955, #42958
- Failed merges:
@bors bors merged commit 45af6ee into rust-lang:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@stepancheg @rust-highfive @alexcrichton @bors @Mark-Simulacrum @kennytm @carols10cents @arielb1 @sfackler