Skip to content

Deprecate range-specific step_by #42310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2017
Merged

Deprecate range-specific step_by #42310

merged 3 commits into from
Jun 3, 2017

Conversation

scottmcm
Copy link
Member

Deprecation attributes and test updates only.

Was replaced by an any-iterator version in #41439

Last follow-up (this release) to #42110 (comment)

r? @alexcrichton

@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 30, 2017
@alexcrichton
Copy link
Member

Looks great to me, thanks! I think there's one remaining CI error though?

[01:03:21] error: use of deprecated item: replaced by `Iterator::step_by`
[01:03:21]    --> /checkout/src/libcollections/../libcollections/tests/vec_deque.rs:513:21
[01:03:21]     |
[01:03:21] 513 |     let seq = (0..).step_by(2).take(256);
[01:03:21]     |                     ^^^^^^^
[01:03:21]     |
[01:03:21]     = note: #[deny(deprecated)] implied by #[deny(warnings)]
[01:03:21] note: lint level defined here
[01:03:21]    --> /checkout/src/libcollections/../libcollections/tests/lib.rs:11:9
[01:03:21]     |
[01:03:21] 11  | #![deny(warnings)]
[01:03:21]     |         ^^^^^^^^
[01:03:21] 
[01:03:21] error: aborting due to previous error(s)
[01:03:21] 
[01:03:21] error: Could not compile `collections`.

@scottmcm
Copy link
Member Author

Oops, I missed a step. Closing temporarily; will re-open after #42315.

@scottmcm scottmcm closed this May 30, 2017
scottmcm added 3 commits May 31, 2017 22:35
@scottmcm
Deprecate Range*::step_by
0967e24 
Changed all the tests except test_range_step to use Iterator::step_by.
@scottmcm
Deprecate iter::range::StepBy
1723e06 
Only exposed as DeprecatedStepBy (as of PR 41439)
@scottmcm
Avoid range::step_by in another test
15dff84
@scottmcm
Copy link
Member Author

scottmcm commented Jun 1, 2017

Reopening as #42315 has landed, allowing some more tests to be moved over to Iterator::step_by.

@scottmcm scottmcm reopened this Jun 1, 2017
@scottmcm scottmcm force-pushed the deprecate-range-stepby branch from 9430117 to 15dff84 Compare June 1, 2017 06:10
@alexcrichton alexcrichton added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2017
@alexcrichton
Copy link
Member

@bors: r+

Thanks @scottmcm!

@bors
Copy link
Collaborator

bors commented Jun 1, 2017

📌 Commit 15dff84 has been approved by alexcrichton

@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 1, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42310 - scottmcm:deprecate-range-stepby, r=…
d38fa91 
…alexcrichton

Deprecate range-specific `step_by`

Deprecation attributes and test updates only.

Was replaced by an any-iterator version in rust-lang#41439

Last follow-up (this release) to rust-lang#42110 (comment)

r? @alexcrichton
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 1, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 1, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42310 - scottmcm:deprecate-range-stepby, r=…
7b77904 
…alexcrichton

Deprecate range-specific `step_by`

Deprecation attributes and test updates only.

Was replaced by an any-iterator version in rust-lang#41439

Last follow-up (this release) to rust-lang#42110 (comment)

r? @alexcrichton
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 1, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Jun 2, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 2, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42310 - scottmcm:deprecate-range-stepby, r=…
2a77cf1 
…alexcrichton

Deprecate range-specific `step_by`

Deprecation attributes and test updates only.

Was replaced by an any-iterator version in rust-lang#41439

Last follow-up (this release) to rust-lang#42110 (comment)

r? @alexcrichton
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 2, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 2, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42310 - scottmcm:deprecate-range-stepby, r=…
1316281 
…alexcrichton

Deprecate range-specific `step_by`

Deprecation attributes and test updates only.

Was replaced by an any-iterator version in rust-lang#41439

Last follow-up (this release) to rust-lang#42110 (comment)

r? @alexcrichton
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 2, 2017
Merged
bors added a commit that referenced this pull request Jun 2, 2017
@bors
Auto merge of #42381 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
536e9b8 
Rollup of 10 pull requests

- Successful merges: #41981, #42225, #42310, #42319, #42335, #42343, #42355, #42360, #42370, #42372
- Failed merges:
bors added a commit that referenced this pull request Jun 2, 2017
@bors
Auto merge of #42381 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
bb907ad 
Rollup of 10 pull requests

- Successful merges: #41981, #42225, #42310, #42319, #42335, #42343, #42355, #42360, #42370, #42372
- Failed merges:
@bors bors merged commit 15dff84 into rust-lang:master Jun 3, 2017
@scottmcm scottmcm deleted the deprecate-range-stepby branch June 3, 2017 06:01
@kennytm kennytm mentioned this pull request Jun 16, 2017
Merged
@scottmcm scottmcm mentioned this pull request Jul 2, 2017
Merged
bors added a commit that referenced this pull request Jul 4, 2017
@bors
Auto merge of #43012 - scottmcm:delete-range-step-by, r=alexcrichton
7a75d2b 
Delete deprecated & unstable range-specific `step_by`

Using the new one is annoying while this one exists, since the inherent method hides the one on iterator.

Tracking issue: #27741
Replacement: #41439
Deprecation: #42310 for 1.19
Fixes #41477
This was referenced Jul 5, 2017
Merged
Closed
bors added a commit that referenced this pull request Jul 8, 2017
@bors
Auto merge of #43077 - SimonSapin:ranges, r=alexcrichton
4d4d76c 
Implement O(1)-time Iterator::nth for Range*, and slim the Step trait

Fixes #43064.
Fixes part of #39975.
Fixes items 1 <s>and 3</s> of #42168.
CC #27741.

I think #42310 and #43012 should not have landed without the `nth` part of this PR, but oh well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scottmcm @alexcrichton @bors @Mark-Simulacrum @frewsxcv