Rollup of 7 pull requests #39260
Merged
Rollup of 7 pull requests #39260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching enums with named fields in the previous way yielded the "non_shorthand_field_patterns" warning. The new code shows the shorthand syntax as well as field renaming, so it should be exhaustive ;-)
The book currently claims that the `size` and `align` fields in the trait object vtable are not used, but this is false. These two fields are used by the stable `mem::size_of_val` and `mem::align_of_val` functions. See the `ty::TyDynamic` case of the `glue::size_and_align_of_dst` function in librustc_trans, which is used to implement both intrinsics in the unsized case.
book: match enum warning Matching enums with named fields in the previous way yielded the "non_shorthand_field_patterns" warning. The new code shows the shorthand syntax as well as field renaming, so it should be exhaustive ;-)
…nd-38830, r=steveklabnik Update struct_expr grammar for field init shorthand. Part of the work for rust-lang#38830 . r? @steveklabnik
Add `&mut expr` to syntax index
…ze-and-align, r=steveklabnik book: size and align in trait object vtables are used The book currently claims that the `size` and `align` fields in the trait object vtable are not used, but this is false. These two fields are used by the stable `mem::size_of_val` and `mem::align_of_val` functions. See the `ty::TyDynamic` case of the `glue::size_and_align_of_dst` function in librustc_trans, which is used to implement both intrinsics in the unsized case. r? @steveklabnik
Docs for atomic orderings: link to the 'nomicon article for further reading
…umeGomez Add more references between lowercase/uppercase operations. None
build: Mention rustbuild in Makefile.in comments I think this patch will help newcomers like myself with the build system. I didn't understand that the make targets listed in the Makefile.in comments only worked with the old system, until it was pointed out to me in rust-lang#39256.
Contributor
Author
|
@bors: r+ p=1 |
Collaborator
|
📌 Commit d7c5f0d has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Jan 23, 2017
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&mut exprto syntax index #38993, book: size and align in trait object vtables are used #39191, Docs for atomic orderings: link to the 'nomicon article for further reading #39200, Add more references between lowercase/uppercase operations. #39233, build: Mention rustbuild in Makefile.in comments #39258