Don't restrict docs in compiler-docs mode #38929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Isn't the search index for the compiler docs not completely broken anyway: #34800? I agree that the compiler docs should include docs for all crates that |
|
Yeah, it's broken anyway, this just makes it more broken 😄 |
|
Could you add a comment here as well? Out of the blue such a conditional seems like it would be quite odd. |
|
(other than that r=me) |
Manishearth
force-pushed
the
compiler-docs
branch
from
412ce51 to
af00927
Compare
|
@bors-servo r=alexcrichton |
|
📌 Commit af00927 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 9, 2017
Don't restrict docs in compiler-docs mode Search is broken without this. We want all crates to be included in compiler-docs mode. This was changed in #38858, this PR brings that functionality back in compiler-docs mode.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search is broken without this. We want all crates to be included in compiler-docs mode. This was changed in #38858, this PR brings that functionality back in compiler-docs mode.