Don't warn about dead foreign items if the 'allow(dead_code)' attribute is present #38791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te is present This functionality was missing, and should have existed previously. Fixes rust-lang#38780
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
approved these changes
Jan 3, 2017
| @@ -445,6 +445,11 @@ impl<'a, 'tcx> DeadVisitor<'a, 'tcx> { | |||
| && !has_allow_dead_code_or_lang_attr(&variant.attrs) | |||
| } | |||
|
|
|||
| fn should_warn_about_foreign_item(&mut self, fi: &hir::ForeignItem) -> bool { | |||
| !self.symbol_is_live(fi.id, None) | |||
| && !has_allow_dead_code_or_lang_attr(&fi.attrs) | |||
There was a problem hiding this comment.
Pre-existing but why do we snoop lint attributes instead of registering the lints and letting the lint pass track them? cc @rust-lang/compiler
|
@bors r+ |
|
📌 Commit 09178e4 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 3, 2017
Don't warn about dead foreign items if the 'allow(dead_code)' attribute is present This functionality was missing, and should have existed previously. Fixes #38780
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality was missing, and should have existed previously.
Fixes #38780