-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add missing urls and examples to TcpStream #38004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
426ebb3
to
56529cd
Compare
/// let stream = TcpStream::connect("127.0.0.1:8080") | ||
/// .expect("Couldn't connect to the server..."); | ||
/// stream.set_nodelay(true).expect("set_nodelay call failed"); | ||
/// assert_eq!(stream.nodelay().unwrap_or(false), true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only change it if you want to, but instead of doing unwrap_or
, you could also:
assert_eq!(stream.nodelay(), Ok(true));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this way if you don't mind.
@GuillaumeGomez Up to you if you want to address that comment, otherwise r=me |
@bors: r=frewsxcv |
📌 Commit 56529cd has been approved by |
⌛ Testing commit 56529cd with merge 9a86579... |
Add missing urls and examples to TcpStream r? @frewsxcv
r? @frewsxcv