Skip to content

Add missing urls and examples to TcpStream #38004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Nov 27, 2016
Merged

Add missing urls and examples to TcpStream #38004

bors merged 1 commit into from
Nov 27, 2016

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 25, 2016

@frewsxcv
Copy link
Contributor

frewsxcv commented Nov 25, 2016 

	error[E0061]: this function takes 0 parameters but 1 parameter was supplied
 --> <anon>:8:19
  |
8 | stream.take_error(100).expect("No error was expected...");
  |                   ^^^ expected 0 parameters
error: aborting due to previous error(s)

frewsxcv
frewsxcv reviewed Nov 26, 2016
View reviewed changes
src/libstd/net/tcp.rs
/// let stream = TcpStream::connect("127.0.0.1:8080")
/// .expect("Couldn't connect to the server...");
/// stream.set_nodelay(true).expect("set_nodelay call failed");
/// assert_eq!(stream.nodelay().unwrap_or(false), true);
Copy link
Contributor

@frewsxcv frewsxcv Nov 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change it if you want to, but instead of doing unwrap_or, you could also:

assert_eq!(stream.nodelay(), Ok(true));

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Nov 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this way if you don't mind.

@frewsxcv
Copy link
Contributor

frewsxcv commented Nov 26, 2016

@GuillaumeGomez Up to you if you want to address that comment, otherwise r=me

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Nov 26, 2016

@bors: r=frewsxcv

@bors
Copy link
Collaborator

bors commented Nov 26, 2016

📌 Commit 56529cd has been approved by frewsxcv

@bors
Copy link
Collaborator

bors commented Nov 26, 2016

⌛ Testing commit 56529cd with merge 9a86579...

bors added a commit that referenced this pull request Nov 26, 2016
@bors
Auto merge of #38004 - GuillaumeGomez:tcp_stream_doc, r=frewsxcv
9a86579 
Add missing urls and examples to TcpStream

r? @frewsxcv
@bors
Copy link
Collaborator

bors commented Nov 27, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: frewsxcv
Pushing 9a86579 to master...

@bors bors merged commit 56529cd into rust-lang:master Nov 27, 2016
@GuillaumeGomez GuillaumeGomez deleted the tcp_stream_doc branch November 27, 2016 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frewsxcv frewsxcv frewsxcv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@frewsxcv frewsxcv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez @frewsxcv @bors