Skip to content

Always statically link llvm #36996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Always statically link llvm #36996

wants to merge 1 commit into from

Conversation

brianp
Copy link

@brianp brianp commented Oct 6, 2016

As suggested we basically always want to link LLVM statically.

Closes #36854

As suggested we basically always want to link LLVM statically.

Closes #36854
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Looks like the --link-static flag may not exist on LLVM 3.7 (which Travis using)?

@brianp
Copy link
Author

brianp commented Oct 13, 2016

@alexcrichton I'm not sure I know how to proceed with that. Should we be flagging it based on the versions or making sure travis uses a higher version?

@alexcrichton
Copy link
Member

Ah yeah we should conditionalize passing this flag based on the version of LLVM, e.g. only pass it on greater versions.

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to resubmit with comments addressed!

pweyck added a commit to pweyck/rust that referenced this pull request Nov 6, 2016
Run llvm-config with "--link-static" if available, to force static linking of LLVM.
This option was added in LLVM 3.8.

Fixes rust-lang#36854
See also: rust-lang#36996
bors added a commit that referenced this pull request Nov 6, 2016
Force static linking of LLVM

Run `llvm-config` with `--link-static` if available, to force static linking of LLVM.
This option was added in LLVM 3.8.

This is my first pull request, any feedback is welcome!

Fixes #36854
See also: #36996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants